RFR: 8251505: Use of types in compiler shared code should be consistent. [v4]

Paul Hohensee phh at openjdk.java.net
Tue Feb 1 21:09:11 UTC 2022


On Tue, 1 Feb 2022 18:38:49 GMT, Yi-Fan Tsai <duke at openjdk.java.net> wrote:

>> 8251505: Use of types in compiler shared code should be consistent.
>
> Yi-Fan Tsai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unintentional formatting

Why not use 'jlong' everywhere instead of int64_t? You've got a mix of them (well, compileBroker.* uses jlong), better to be consistent.. Ditto INT64_FORMAT and JLONG_FORMAT. You'd also avoid declaring "declare_integer_type(int64_t)" in vmStructs.cpp.

In gc_globals.hpp, use of intx is likely intentional, so I'd leave it alone. intx resolves to intptr_t (see globalDefinitions.hpp), which is 32 bits on 32-bit systems and 64 bits on 64-bit ones, which is what you want.

-------------

Changes requested by phh (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7294


More information about the hotspot-dev mailing list