RFR: 8251505: Use of types in compiler shared code should be consistent. [v6]
David Holmes
dholmes at openjdk.java.net
Tue Feb 1 23:15:11 UTC 2022
On Tue, 1 Feb 2022 23:08:48 GMT, Yi-Fan Tsai <duke at openjdk.java.net> wrote:
>> 8251505: Use of types in compiler shared code should be consistent.
>
> Yi-Fan Tsai has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>
> Use jlong instead of int64_t
Do not use jlong everywhere. We should only be using jlong where we have values that will interact with Java code and so have to be jlong to be compatible. Otherwise for a 64-bit type we should be using int64_t, or uint64_t as appropriate. For a type that should be 32-bit or 64-bit depending on the environment we should use intx, intptr_t or size_t depending on the nature of the variable.
Also do not force-push changes, just commit any changes as normal and push them. When the change is integrated the skara tooling will flatten things into one clean commit. If you force-push you mess up the PR review process.
Thanks.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7294
More information about the hotspot-dev
mailing list