RFR: JDK-8281023: NMT integration into pp debug command does not work [v2]

Thomas Stuefe stuefe at openjdk.java.net
Thu Feb 3 05:37:47 UTC 2022


On Wed, 2 Feb 2022 13:30:26 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Zhengyus remarks
>
> src/hotspot/share/services/mallocTracker.cpp line 301:
> 
>> 299: bool MallocTracker::print_pointer_information(const void* p, outputStream* st) {
>> 300:   assert(MemTracker::enabled(), "NMT must be enabled");
>> 301:   if (CanUseSafeFetchN() && os::is_readable_pointer(p)) {
> 
> `os::is_readable_pointer()` uses `CanUseSafeFetch32()`, you may want to check `CanUseSafeFetch32()` instead of `CanUseSafeFetchN()`.

Good point. Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7297


More information about the hotspot-dev mailing list