RFR: JDK-8281023: NMT integration into pp debug command does not work [v3]

[Thomas Stuefe]

On Thu, 3 Feb 2022 07:37:40 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> > Note that I think @iklam was overcautious in the original discussion. We already risk signals in the debugging session by using SafeFetch to read the malloc header. Using a reference to a potentially dead ReservedMemoryRegion runs an additional - very low - risk of signals. So, if we really want to be cautious, we should not print out NMT information at all in pp. But I think NMT is very useful and worth the risk. All we risk is a slightly miffed debugger.
> 
> I wasn't trying to make life unnecessarily difficult, and I agree that printing out the NMT info is a great idea.
> 
> All I was suggesting was -- if there's a less risky way to do the printing and that's no overly complicated, we should do it that way. And the new code looks good to me.

Thank you for the review!

If pp() were used outside of debugging, I'd agree with your original estimate.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7297