RFR: 8072070: Improve interpreter stack banging [v2]
Aleksey Shipilev
shade at openjdk.java.net
Mon Feb 7 07:31:10 UTC 2022
On Sat, 5 Feb 2022 05:50:34 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> > since you this PR touches stackoverflow.hpp, Could you also take a look at this? https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/stackOverflow.cpp#L66
> > we actually get the page size from os. why do we need alignment = 4k?
>
> Look here:
>
> https://github.com/openjdk/jdk/blob/48523b090886f7b24ed4009f0c150efaa6f7b056/src/hotspot/share/runtime/stackOverflow.cpp#L42-L45
> -- the `StackYellowPages`, `StackRedPages`, `StackShadowPages` are defined in as 4K pages. It should probably be called `unit`, not `alignment`. I'd like to avoid scope creep for this PR, so that's for another day.
Done in #7362.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7247
More information about the hotspot-dev
mailing list