RFR: 8072070: Improve interpreter stack banging [v3]

Aleksey Shipilev shade at openjdk.java.net
Tue Feb 8 07:18:54 UTC 2022


On Tue, 8 Feb 2022 03:57:07 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More comments
>
> src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp line 739:
> 
>> 737:   __ cmpptr(Address(thread, JavaThread::shadow_zone_safe_limit()), (int32_t)NULL_WORD);
>> 738:   __ jcc(Assembler::notEqual, L_good_limit);
>> 739:     __ stop("shadow zone safe limit is not initialized");
> 
> This indentation seems strange to me.
> Also see lines {745, 762}.
> 
> And we'd better update the copyright year for all touched files.

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7247


More information about the hotspot-dev mailing list