RFR: 8280832: Update usage docs for NonblockingQueue

David Holmes dholmes at openjdk.java.net
Wed Feb 9 00:43:03 UTC 2022


On Tue, 8 Feb 2022 22:58:26 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this update of the usage and implementation comments for
> NonblockingQueue to discuss the ABA issue in push/append operations.

src/hotspot/share/utilities/nonblockingQueue.inline.hpp line 122:

> 120:     // try_pop could take old_tail before our update, it gets recycled and
> 121:     // re-added to the end, and then we successfully cmpxchg, rendering the
> 122:     // list in _tail circular.

Doesn't this contradict the "We won any races with try_pop ... so we're done"!

-------------

PR: https://git.openjdk.java.net/jdk/pull/7393


More information about the hotspot-dev mailing list