RFR: 8280832: Update usage docs for NonblockingQueue

Ivan Walulya iwalulya at openjdk.java.net
Wed Feb 9 10:14:06 UTC 2022


On Tue, 8 Feb 2022 22:58:26 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this update of the usage and implementation comments for
> NonblockingQueue to discuss the ABA issue in push/append operations.

Minor suggestion

src/hotspot/share/utilities/nonblockingQueue.inline.hpp line 120:

> 118:     // old_tail for extension.  We won any races with try_pop by changing
> 119:     // away from end-marker.  So we're done.  Note that ABA is possible;
> 120:     // try_pop could take old_tail before our update, it gets recycled and

"a concurrent try_pop could take...."

-------------

Marked as reviewed by iwalulya (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7393


More information about the hotspot-dev mailing list