RFR: 8280916: Simplify HotSpot Style Guide editorial changes

Kim Barrett kbarrett at openjdk.java.net
Tue Feb 15 06:52:08 UTC 2022


On Mon, 31 Jan 2022 22:14:32 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Please review this change to the HotSpot Style Guide change process.
>> 
>> The current process involves gathering consensus among the HotSpot Group
>> Members.  That's fine for changes of substance.  But it seems overly weighty
>> for editorial changes that don't affect the substance of the guide, but only
>> it's clarity or accuracy.
>> 
>> The proposed change would permit the normal PR process to be used for such
>> changes, but require the requisite reviewers to additionally be HotSpot Group
>> Members.
>> 
>> Note that there have already been a couple of changes that effectively
>> followed the proposed new process.
>> https://bugs.openjdk.java.net/browse/JDK-8274169
>> https://bugs.openjdk.java.net/browse/JDK-8280182
>> 
>> This is a modification of the Style Guide, so rough consensus among the
>> HotSpot Group members is required to make this change. Only Group members
>> should vote for approval (via the github PR), though reasoned objections or
>> comments from anyone will be considered. A decision on this proposal will not
>> be made before Monday 14-Feb-2022 at 12h00 UTC.
>> 
>> Since we're piggybacking on github PRs here, please use the PR review process
>> to approve (click on Review Changes > Approve), rather than sending a "vote:
>> yes" email reply that would be normal for a CFV.
>
> Approved.

Thanks @vnkozlov and all the other reviewers.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7281


More information about the hotspot-dev mailing list