RFR: 8214976: Warn about uses of functions replaced for portability [v5]
Harold Seigel
hseigel at openjdk.java.net
Tue Feb 15 18:29:14 UTC 2022
On Mon, 14 Feb 2022 22:37:39 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>>
>> rename macro, fix semi-colon issue, fix zero lseek64 and ftruncate64 build issue
>
> src/hotspot/os/linux/os_linux.cpp line 4924:
>
>> 4922: }
>> 4923:
>> 4924: off64_t call_lseek64(int fd, off64_t offset, int whence) {
>
> I think it would be better to just change the `lseek64` calls to `os::lseek` rather than introduce this wrapper function.
Thanks David. I changed the code to call os::lseek().
-------------
PR: https://git.openjdk.java.net/jdk/pull/7248
More information about the hotspot-dev
mailing list