RFR: 8214976: Warn about uses of functions replaced for portability [v6]

[David Holmes]

On Tue, 15 Feb 2022 18:22:00 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Please review this new attempt to resolve JDK-8214976.  This fix adds Pragmas to generate compilation errors, when using gcc, if calling a native system function instead of the os:: version of the function.  The fix includes changes to calls in non-shared code because it is cleaner than adding PRAGMAs and, for some cases, the os:: version of a function has added value, such as asserts and RESTARTABLE.  This fix slightly changes the signature of os::abort() so it wouldn't conflict with native abort() functions.  Changes to Windows code is left for a future RFE.
>> 
>> This fix was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, Mach5 tiers 3-5 on Linux x64, and Mach5 builds of Zero, PPC, and s390.
>> 
>> Thanks, Harold
>
> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   change lseek64() calls to os::lseek()

Thanks Harold,

This seems acceptable to me now. Only remaining issue is the placement issue Kim raised - see query/suggestion below.

David

-------------

PR: https://git.openjdk.java.net/jdk/pull/7248