RFR: 8282306: os::is_first_C_frame(frame*) crashes on invalid link access [v2]

Johannes Bechberger duke at openjdk.java.net
Wed Feb 23 16:10:29 UTC 2022


On Wed, 23 Feb 2022 15:39:42 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve use of C macros
>
> src/hotspot/share/runtime/os.cpp line 1227:
> 
>> 1225:          !t->is_in_full_stack((address)fr->fp()) ||
>> 1226:          !t->is_in_full_stack((address)fr->sender_sp()) ||
>> 1227:          !t->is_in_full_stack((address)fr->link());
> 
> Should probably use
> #ifdef _WINDOWS
> ...
> #else
> ...
> #endif
> 
> here

And also in the original method

-------------

PR: https://git.openjdk.java.net/jdk/pull/7591


More information about the hotspot-dev mailing list