RFR: 8282306: os::is_first_C_frame(frame*) crashes on invalid link access [v2]

[Johannes Bechberger]

On Wed, 23 Feb 2022 20:29:43 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve use of C macros
>
> src/hotspot/share/utilities/vmError.cpp line 338:
> 
>> 336:       // is_first_C_frame() does only simple checks for frame pointer,
>> 337:       // it will pass if java compiled code has a pointer in EBP.
>> 338:       if (os::is_first_C_frame(&fr, t)) return invalid;
> 
> Is the comment still accurate?

I think so? But maybe removing the second line would be helpful.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7591