RFR: 8282240: Add _name field to Method for NOT_PRODUCT only [v2]

[Patricio Chilano Mateo]

On Thu, 24 Feb 2022 14:03:49 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Whenever I'm debugging I really wish I knew the name of the method that I'm looking at, so I added this field in not-product.
>> Tested with tier1 on Oracle platforms.
>
> Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Enhance comment to say why name needs to be set later.
>  - 8282240: Add _name field to Method for NOT_PRODUCT only
>  - Merge branch 'master' into method-name
>  - Enhance comment to say why name needs to be set later.
>  - 8282240: Add _name field to Method for NOT_PRODUCT only

Hi Coleen,

Looks good to me. I see we also call set_constants() and set_name_index() from VM_RedefineClasses::set_new_constant_pool(), do we need to set the name in there too or it's not needed?

Thanks,
Patricio

-------------

Marked as reviewed by pchilanomate (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7608