RFR: 8282240: Add _name field to Method for NOT_PRODUCT only [v2]
Coleen Phillimore
coleenp at openjdk.java.net
Fri Feb 25 20:19:32 UTC 2022
On Thu, 24 Feb 2022 14:03:49 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Whenever I'm debugging I really wish I knew the name of the method that I'm looking at, so I added this field in not-product.
>> Tested with tier1 on Oracle platforms.
>
> Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Enhance comment to say why name needs to be set later.
> - 8282240: Add _name field to Method for NOT_PRODUCT only
> - Merge branch 'master' into method-name
> - Enhance comment to say why name needs to be set later.
> - 8282240: Add _name field to Method for NOT_PRODUCT only
Hi Patricio, In the RedefineClasses case, the methods already have the _name field set. But your comment pointed out the fragility of this change, so I changed it. Hope this one is better. Please re-review.
Harold, can you re-review also?
-------------
PR: https://git.openjdk.java.net/jdk/pull/7608
More information about the hotspot-dev
mailing list