RFR: 8282306: os::is_first_C_frame(frame*) crashes on invalid link access [v9]

[Thomas Stuefe]

On Sat, 26 Feb 2022 05:54:05 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix tests
>
> src/hotspot/share/runtime/os.cpp line 1193:
> 
>> 1191: 
>> 1192:   uintptr_t usp    = (uintptr_t)fr->sp();
>> 1193:   if ((usp & sp_align_mask) != 0 || !os::is_readable_pointer((const void*)usp)) return true;
> 
> remove cast

Also, could you factor out this test to a local helper, something like:

static bool pointer_is_bad(uintptr_t p) {
...
}

?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7591