RFR: 8278602: CDS dynamic dump may access unloaded classes [v5]

[Ioi Lam]

On Thu, 16 Dec 2021 08:30:21 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>> 
>>  - Merge branch 'master' into 8278602-cds-zgc-class-unload-bug
>>  - @calvinccheung comments -- removed unused code
>>  - Merge branch 'master' into 8278602-cds-zgc-class-unload-bug
>>  - added test case
>>  - @coleenp and @stefank review comments
>>  - cleaned up code
>>  - add #if INCLUDE_CDS
>>  - Merge branch 'master' into 8278602-cds-zgc-class-unload-bug
>>  - using k->is_loader_alive() is enough
>>  - Added DumpTimeSharedClassTable::iterate() to make sure every iteration goes through EligibleClassIterationHelper
>>  - ... and 1 more: https://git.openjdk.java.net/jdk/compare/2a59ebbb...41e0b8ed
>
> I've reviewed the interaction of the klasses in the _dumptime_table with the new is_loader_alive() check. I don't know the reset of the CDS code to know if the other changes are correct or not. I spotted something that looks weird:

Thanks @stefank @calvinccheung @coleenp for the review. Latest version passed Mach5 CI tiers 1-4.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6859