RFR: 8279282: [vectorapi] Matcher::supports_vector_comparison_unsigned is not needed on x86

Paul Sandoz psandoz at openjdk.java.net
Wed Jan 5 21:38:19 UTC 2022


On Wed, 5 Jan 2022 21:18:40 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> Do we have tests which verify correctness of unsigned compare?

Yes, we test against the cross product of [cases]( https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/incubator/vector/Int256VectorTests.java#L984) for all comparison operations. See use of `intCompareOpProvider` as a data provider.

(As for all other operations the test assumes the C2 compiler is triggered, reasonable for these cases. However, I think we should completely rewrite the tests using the IR framework. It's a non-trivial amount of work but i think possible, especially with similar source code generation techniques we already use and the ability to query at runtime what IR nodes are supported.)

-------------

PR: https://git.openjdk.java.net/jdk/pull/6966


More information about the hotspot-dev mailing list