RFR: JDK-8278329: some TraceDeoptimization code not included in PRODUCT build [v2]
Tom Rodriguez
never at openjdk.java.net
Thu Jan 6 17:58:20 UTC 2022
On Thu, 6 Jan 2022 14:15:38 GMT, Tobias Holenstein <duke at openjdk.java.net> wrote:
>> After "JDK-8154011: Make `TraceDeoptimization` a diagnostic flag" some code was not included in the PRODUCT build.
>>
>> Removed all the #ifndef PRODUCT guards around `TraceDeoptimization` checks and made sure to be consistent.
>>
>> The DEOPT PACKING messages were controlled by `PrintDeoptimizationDetails` (develop flag), but DEOPT UNPACKING is controlled by `TraceDeoptimization` (product flag),. Therefore changed DEOPT PACKING messages to be controlled by `TraceDeoptimization` as well.
>>
>> Checked that tests are not affected. Checked on Aurora that performance is not affected.
>
> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>
> Cleanup output of TraceDeoptimization
Marked as reviewed by never (Reviewer).
Yes that output looks great to me. Thank you for taking the time to do this.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6746
More information about the hotspot-dev
mailing list