RFR: 8218857: Confusing overloads for os::open

Harold Seigel hseigel at openjdk.java.net
Fri Jan 7 13:36:43 UTC 2022


Please review this small change to resolve overload confusion by renaming "FILE* os::open(int fd, const char* mode)" to "FILE* os::fdopen(int fd, const char* mode)" in os.hpp.  The change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.

Thanks, Harold

-------------

Commit messages:
 - 8218857: Confusing overloads for os::open

Changes: https://git.openjdk.java.net/jdk/pull/6988/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6988&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8218857
  Stats: 12 lines in 6 files changed: 0 ins; 0 del; 12 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6988.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6988/head:pull/6988

PR: https://git.openjdk.java.net/jdk/pull/6988


More information about the hotspot-dev mailing list