RFR: JDK-8278329: some TraceDeoptimization code not included in PRODUCT build [v2]

[David Holmes]

Hi Tobias,

On 7/01/2022 8:56 pm, Tobias Holenstein wrote:
> On Fri, 7 Jan 2022 07:28:23 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
> 
>>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>>>
>>>    Cleanup output of TraceDeoptimization
>>
>> src/hotspot/share/runtime/deoptimization.cpp line 1954:
>>
>>> 1952: #if INCLUDE_JVMCI
>>> 1953:             , debug_id
>>> 1954: #endif
>>
>> You can use `JVMCI_ONLY` here as well. Same in line 1840.
> 
> Unfortunately, because of the comma and the way JVMCI_ONLY is defined, this does not work. I will leave it as it is

We have the COMMA macro to solve that problem e.g.

./share/runtime/threadSMR.inline.hpp:  DEBUG_ONLY(COMMA _list(list))

Cheers,
David


> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/6746