RFR: 8218857: Confusing overloads for os::open

Harold Seigel hseigel at openjdk.java.net
Mon Jan 10 13:58:31 UTC 2022


On Fri, 7 Jan 2022 13:29:38 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review this small change to resolve overload confusion by renaming "FILE* os::open(int fd, const char* mode)" to "FILE* os::fdopen(int fd, const char* mode)" in os.hpp.  The change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.
> 
> Thanks, Harold

Thanks Kim and Robbin for the reviews.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6988


More information about the hotspot-dev mailing list