Integrated: 8142362: Lots of code duplication in Copy class
Coleen Phillimore
coleenp at openjdk.java.net
Mon Jan 10 14:40:35 UTC 2022
On Thu, 6 Jan 2022 20:45:39 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> Removed an unused assembly function on one platform (_Copy_conjoint_bytes), and consolidated the linux and bsd x86, and linux and bsd aarch64 copy code that was duplicated. There's unfortunately now an #ifndef _WINDOWS in copy_x86.hpp and copy_aarch64.hpp, and I couldn't combine the duplicate copy_<arch>.S files because Windows doesn't have this file (and couldn't convince the build system to ignore the .S file for windows).
> I didn't think it was worth adding an os_cpu/posix_x86 and os_cpu/posix_aarch64 directory for this small bit of code.
>
> There could be more consolidation but the platform differences are subtle. This change just moves around code without poking this bear.
>
> Tested with tier1 on Oracle platforms, build on linux-x86-open,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug and Zero (zero in progress).
This pull request has now been integrated.
Changeset: 76477f8c
Author: Coleen Phillimore <coleenp at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/76477f8cdbc012f7ff0670ad57067ebf304612a0
Stats: 1628 lines in 11 files changed: 451 ins; 1162 del; 15 mod
8142362: Lots of code duplication in Copy class
Reviewed-by: kvn, hseigel
-------------
PR: https://git.openjdk.java.net/jdk/pull/6984
More information about the hotspot-dev
mailing list