RFR: 8279668: x86: AVX2 versions of vpxor should be asserted [v4]

Aleksey Shipilev shade at openjdk.java.net
Mon Jan 10 18:25:11 UTC 2022


> Got the SIGILLs on some machines when testing JDK-8279621. That patch started using shorter `vpxor` versions on `UseAVX = 1` path, which tried to use `VEX.256`-encoded `vpxor` instruction that is only available on AVX2. This should be at very least asserted in assembler code. 
> 
> Also fixed the implicit `bool` -> `int` conversion to `vector_len`.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug `tier1` with `-XX:UseAVX=1`

Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Review comments
 - Merge branch 'master' into JDK-8279668-vpxor-avx2
 - Add more asserts
 - Use AVX_256bit literal
 - Fix

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7005/files
  - new: https://git.openjdk.java.net/jdk/pull/7005/files/194bfa09..483e8e65

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7005&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7005&range=02-03

  Stats: 6610 lines in 172 files changed: 4268 ins; 1779 del; 563 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7005.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7005/head:pull/7005

PR: https://git.openjdk.java.net/jdk/pull/7005


More information about the hotspot-dev mailing list