RFR: 8279668: x86: AVX2 versions of vpxor should be asserted [v3]

Aleksey Shipilev shade at openjdk.java.net
Mon Jan 10 18:25:15 UTC 2022


On Mon, 10 Jan 2022 13:31:42 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add more asserts
>
> src/hotspot/cpu/x86/macroAssembler_x86.hpp line 1493:
> 
>> 1491:   // Simple version for AVX2 256bit vectors
>> 1492:   void vpxor(XMMRegister dst, XMMRegister src) {
>> 1493:     assert(UseAVX >= 2, "Only with AVX2");
> 
> I would suggest the assert msg as "Only with AVX2 or above".
> We should also update the copyright year.

Rephrased the assert message, updated copyright date. Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/7005


More information about the hotspot-dev mailing list