RFR: 8248404: AArch64: Remove uses of long and unsigned long [v2]

Stefan Karlsson stefank at openjdk.java.net
Tue Jan 11 08:51:28 UTC 2022


On Tue, 11 Jan 2022 04:07:51 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Tested with mach5 on linux-aarch64 and macosx-aarch64 on tier1-3 and below GHA for windows-aarch64 (once I open this PR).
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Cast Address operand to int

Changes requested by stefank (Reviewer).

src/hotspot/cpu/aarch64/macroAssembler_aarch64_log.cpp line 300:

> 298:     fmovs(tmp3, vtmp5);                        // int intB0 = AS_INT_BITS(B);
> 299:     mov(tmp5, 0x3FE0);
> 300:     uint64_t mask = 0xffffe00000000000UL;

I think this should be using ULL to support LLP64.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7023


More information about the hotspot-dev mailing list