RFR: 8248404: AArch64: Remove uses of long and unsigned long [v2]

Andrew Haley aph at openjdk.java.net
Tue Jan 11 10:49:29 UTC 2022


On Tue, 11 Jan 2022 04:07:51 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Tested with mach5 on linux-aarch64 and macosx-aarch64 on tier1-3 and below GHA for windows-aarch64 (once I open this PR).
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Cast Address operand to int

src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp line 499:

> 497: #ifdef __APPLE__
> 498:   // macosx wants all the overloads
> 499:   inline void mov(Register dst, intptr_t imm32)           { mov_immediate64(dst, imm32); }

Suggestion:

  inline void mov(Register dst, intptr_t imm64)           { mov_immediate64(dst, imm64); }

src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp line 501:

> 499:   inline void mov(Register dst, intptr_t imm32)           { mov_immediate64(dst, imm32); }
> 500: #endif
> 501:   inline void mov(Register dst, int64_t imm32)           { mov_immediate64(dst, imm32); }

Suggestion:

  inline void mov(Register dst, int64_t imm64)           { mov_immediate64(dst, imm64); }

src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp line 502:

> 500: #endif
> 501:   inline void mov(Register dst, int64_t imm32)           { mov_immediate64(dst, imm32); }
> 502:   inline void mov(Register dst, uint64_t imm32)           { mov_immediate64(dst, imm32); }

Suggestion:

  inline void mov(Register dst, uint64_t imm64)           { mov_immediate64(dst, imm64); }

-------------

PR: https://git.openjdk.java.net/jdk/pull/7023


More information about the hotspot-dev mailing list