RFR: 8248404: AArch64: Remove uses of long and unsigned long [v2]
Andrew Haley
aph at openjdk.java.net
Tue Jan 11 10:58:23 UTC 2022
On Tue, 11 Jan 2022 10:52:48 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Cast Address operand to int
>
> src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp line 74:
>
>> 72: // Capture prev stack pointer (stack arguments base)
>> 73: __ add(rscratch1, rfp, 16); // Skip saved FP and LR
>> 74: __ str(rscratch1, Address(sp, (int)layout.stack_args)); // x86 casts to int also
>
> Suggestion:
>
> __ str(rscratch1, Address(sp, checked_cast<int>(layout.stack_args))); // x86 casts to int also
... because this is UB if it doesn't fit.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7023
More information about the hotspot-dev
mailing list