RFR: 8248404: AArch64: Remove uses of long and unsigned long [v2]
Quan Anh Mai
duke at openjdk.java.net
Tue Jan 11 15:28:28 UTC 2022
On Tue, 11 Jan 2022 08:45:55 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Cast Address operand to int
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64_log.cpp line 300:
>
>> 298: fmovs(tmp3, vtmp5); // int intB0 = AS_INT_BITS(B);
>> 299: mov(tmp5, 0x3FE0);
>> 300: uint64_t mask = 0xffffe00000000000UL;
>
> I think this should be using ULL to support LLP64.
Integral literal takes the first type that fits so for this 64-bit all U, UL and ULL would produce the same type.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7023
More information about the hotspot-dev
mailing list