RFR: 8248404: AArch64: Remove uses of long and unsigned long [v5]
Coleen Phillimore
coleenp at openjdk.java.net
Tue Jan 11 17:21:06 UTC 2022
On Tue, 11 Jan 2022 17:02:09 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> It seems to silently truncate if the only signed type is int. I just put a breakpoint on `LIR_Assembler::as_Address` and watched it happen.
>
> There are too many overloads. I don't know why long long overloads didn't cause ambiguity but if there's any conversion needed, it's ambiguous.
> Address's _offset field is an int64_t, which seems wrong to assign a unint64_t into it.
I added a ptrdiff_t and a unint64_t overload. The linux build is happy about that. I'm going to push so the GHA tries the rest.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7023
More information about the hotspot-dev
mailing list