RFR: 8248404: AArch64: Remove uses of long and unsigned long [v4]
Andrew Haley
aph at openjdk.java.net
Tue Jan 11 17:21:14 UTC 2022
On Tue, 11 Jan 2022 16:49:30 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Yes, I agree and didn't really know how to fix it so it would compile (if it actually compiles now) and not be UB. I'm close to giving up! Thanks for the code change.
>
> It does seem pedantic which makes it really difficult, but it's important to get this right. These kinds of bugs are horrible to debug.
OK, so if we have the `Address(reg_offset)` overloads for `int`, `int64_t`, and `uint64_t` we're good, and by calling the right overload we get rid of the need to cast the `layout.stack_args` offset to `int` here.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7023
More information about the hotspot-dev
mailing list