RFR: 8238161: use os::fopen in HS code where possible

Coleen Phillimore coleenp at openjdk.java.net
Tue Jan 11 21:25:22 UTC 2022


On Mon, 10 Jan 2022 21:02:54 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review this change to hotspot to call os::fopen() instead of fopen() so that the 'close-on-exec' flag gets set for these opened files.  This change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.  Additionally, the changes were built on Linux PPC.
> 
> Thanks, Harold

Looks good to me.  I assume that you are going to add the pragma forbid function for fopen after this in 8214976 ?

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7022


More information about the hotspot-dev mailing list