RFR: 8248404: AArch64: Remove uses of long and unsigned long [v7]

Patric Hedlin phedlin at openjdk.java.net
Wed Jan 12 09:26:26 UTC 2022


On Tue, 11 Jan 2022 22:38:02 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Tested with mach5 on linux-aarch64 and macosx-aarch64 on tier1-3 and below GHA for windows-aarch64 (once I open this PR).
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add some overloads to Address to keep macosx happy

src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 419:

> 417: #endif
> 418:   Address(Register r, uint64_t o)
> 419:     : _base(r), _index(noreg), _offset(o), _mode(base_plus_offset), _target(0) { }

The above could be written (from an overlapping CS, with additional initialisation)
Suggestion:

    Address(Register r) : Address(r, 0) {}
    Address(Register r, int32_t o) : Address(r, int64_t(o)) {}
    Address(Register r, int64_t o) : _mode(base_plus_offset),
      _base(r), _index(noreg), _offset(o), _extend(lsl(0)), _target(nullptr) {}

    Address(Register r, uint32_t o) : Address(r, uint64_t(o)) {}
    Address(Register r, uint64_t o) : _mode(base_plus_offset),
      _base(r), _index(noreg), _offset(o), _extend(lsl(0)), _target(nullptr) {}

-------------

PR: https://git.openjdk.java.net/jdk/pull/7023


More information about the hotspot-dev mailing list