RFR: 8248404: AArch64: Remove uses of long and unsigned long [v8]

Coleen Phillimore coleenp at openjdk.java.net
Wed Jan 12 21:42:34 UTC 2022


On Wed, 12 Jan 2022 21:35:29 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp line 997:
>> 
>>> 995:     // Calculate address of start element
>>> 996:     if (kind == Interpreter::java_util_zip_CRC32_updateByteBuffer) {
>>> 997:       __ ldr(buf, Address(esp, 2*wordSize)); // jlong buf
>> 
>> Maybe just drop the type in the comment?  Similarly in a couple later places.
>
> Ok. That'll give me less 'long' matches.

No, it's useful because it describes the parameter that you're loading.  I'm leaving this jlong.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7023


More information about the hotspot-dev mailing list