RFR: 8248404: AArch64: Remove uses of long and unsigned long [v8]
Andrew Haley
aph at openjdk.java.net
Thu Jan 13 10:24:33 UTC 2022
On Wed, 12 Jan 2022 21:39:05 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp line 74:
>>
>>> 72: // Capture prev stack pointer (stack arguments base)
>>> 73: __ add(rscratch1, rfp, 16); // Skip saved FP and LR
>>> 74: Address slot = __ legitimize_address(Address(sp, layout.stack_args), wordSize, rscratch2);
>>
>> Introduction of legitimize_address here seems unrelated to this PR. What's this about?
>
> This is a bug that Andrew pointed out. I could file a different CR for this and take it out. It seemed a minor thing to include with this change though.
> Introduction of legitimize_address here seems unrelated to this PR. What's this about?
SP-relative loads and stores have only a 12-bit offset. This is a bug that was discovered during review.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7023
More information about the hotspot-dev
mailing list