RFR: 8279936: Change shared code to use os:: system API's

[David Holmes]

On Wed, 12 Jan 2022 21:56:18 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review this small change to call os:: API's.  the changes were tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.  Most of these changes were for I/O related calls.  Changes to memory allocation calls such as malloc and free will be handled in a future change.
> 
> Thanks, Harold

Hi Harold,

This seems fine except for one change - see below.

I still think we need to discuss whether os::close and os::read should even exist but that is a separate matter.

Thanks,
David

test/hotspot/gtest/gtestMain.cpp line 281:

> 279:     if ((ret = init_jvm(argc, argv, is_vmassert_test, &jvm)) != 0) {
> 280:       fprintf(stderr, "ERROR: JNI_CreateJavaVM failed: %d\n", ret);
> 281:       os::abort();

No this should be the native abort function. We failed to create the VM so we don't/can't use any VM service.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7055