RFR: 8278423: ExtendedDTraceProbes should be deprecated [v2]

[Emanuel Peter]

On Tue, 18 Jan 2022 13:09:57 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Mode of speech edit
>>  - Fix formatting issue
>
> src/hotspot/share/runtime/arguments.cpp line 2883:
> 
>> 2881:     } else if (match_option(option, "-XX:+ExtendedDTraceProbes")) {
>> 2882: #if defined(DTRACE_ENABLED)
>> 2883:       warning("-XX:+ExtendedDTraceProbes is deprecated. Use a combination of -XX:+DTraceMethodProbes, -XX:+DTraceAllocProbes and -XX:+DTraceMonitorProbes instead.");
> 
> Because the flag is deprecated, a deprecation warning will already be generated for it, so this will cause two warnings to be produced. You either put the flag in the  special_jvm_flags table and accept the standard deprecation message, or else you don't put it in the table and handle the deprecation (and later obsoletion) warning directly. In this case the direct approach seems best.

@dholmes-ora : The warning is actually not already generated, since this flag is handled separately, the handling is only done if none of the cases matches, and we land in the `} else if (match_option(option, "-XX:", &tail)) { // -XX:xxxx` case.
I had to add the warning separately now. I think this is a bug though, @tobiasholenstein thought so too. All options should first be checked if they are deprecated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7110