RFR: 8278423: ExtendedDTraceProbes should be deprecated [v4]

[David Holmes]

On Tue, 18 Jan 2022 16:39:04 GMT, Emanuel Peter <duke at openjdk.java.net> wrote:

>> Deprecated ExtendedDTraceProbes.
>> Edited help messages and man pages accordingly.
>> Added flag to VMDeprecatedOptions test.
>> Removed `/src/hotspot/share/services/dtraceAttacher.hpp`: only contained declarations that are never defined or used.
>> 
>> Checked that tests are not affected.
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   moved deprecated flag to deprecated section in manpages

A few more tweaks below.

Thanks,
David

src/hotspot/os/aix/attachListener_aix.cpp line 31:

> 29: #include "runtime/os.inline.hpp"
> 30: #include "services/attachListener.hpp"
> 31: #include "services/dtraceAttacher.hpp"

These changes are somewhat independent of the deprecation issue and could be split out into a separate RFE. The serviceability folk may have an opinion.

src/hotspot/share/runtime/arguments.cpp line 2884:

> 2882: #if defined(DTRACE_ENABLED)
> 2883:       warning("Option ExtendedDTraceProbes was deprecated in version 19 and will likely be removed in a future release.");
> 2884:       warning("Use a combination of -XX:+DTraceMethodProbes, -XX:+DTraceAllocProbes and -XX:+DTraceMonitorProbes instead.");

s/a/the/

Applies to all three uses.

src/java.base/share/man/java.1 line 4001:

> 3999: .TP
> 4000: .B \f[CB]\-XX:+ExtendedDTraceProbes\f[R]
> 4001: Deprecated. Use combination of these flags instead: -XX:+DTraceMethodProbes, -XX:+DTraceAllocProbes, -XX:+DTraceMonitorProbes

Delete "Deprecated" as we are in the deprecated options section.

The wording also needs updating as per the warning text ... though that might read a little odd here so I suggest a tweak:

Use the combination of -XX:+DTraceMethodProbes, -XX:+DTraceAllocProbes and -XX:+DTraceMonitorProbes instead of this deprecated flag.


I would also move that new text to the end, so we still describe the flag first (otherwise it again reads a little odd.)

We will also need to add those flags to the "ADVANCED SERVICEABILITY OPTIONS FOR JAVA" section.

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7110