RFR: 8278036: Saving rscratch1 is optional in MacroAssembler::verify_heapbase

Paul Hohensee phh at openjdk.java.net
Thu Jan 20 20:35:52 UTC 2022


On Thu, 13 Jan 2022 17:44:57 GMT, Yi-Fan Tsai <duke at openjdk.java.net> wrote:

> 8278036: Saving rscratch1 is optional in MacroAssembler::verify_heapbase

verify_heapbase() can only be called in a 64-bit JVM because compressed oops are only supported in a 64-bit JVM. Thus, the #ifdef _LP64 isn't needed.

CheckCompressedOops is only meaningful in a 64-bit JVM, but it's not conditionalized by _LP64 in globals.hpp, even though UseCompressedOops is. This is a bug, imo, that should be addressed in another PR.

-------------

Changes requested by phh (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7067


More information about the hotspot-dev mailing list