RFR: 8276472: align_metadata_size is a nop

[David Holmes]

On Wed, 19 Jan 2022 23:20:37 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> I just added a comment to this and took out the align_up call.  I like align_metadata_size where it is and changing to WordSize doesn't add more safety imo.  Also found unused function while looking for units of metadata size.
> Tested with tier1 on Oracle supported platforms.

Okay. I'm not really sure why we need to make any changes in that case. If the incoming alignment of values were to change then you would want to keep the `align_up` call wouldn't you?

At a minimum should we not have an assertion (static assert?) that the incoming values are actually aligned as expected?

Thanks,
David

Also the issue title is misleading to me as it suggests that being a nop is a problem and that it will be fixed, but it is still a nop after this change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7150