Integrated: 8279534: Consolidate and remove oopDesc::klass_gap methods

Roman Kennke rkennke at openjdk.java.net
Mon Jan 24 11:20:09 UTC 2022


On Mon, 10 Jan 2022 13:40:29 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> After JDK-8278568, these methods are unused:
>   inline int klass_gap() const;
>   inline void set_klass_gap(int z);
> 
> Except Zero which uses set_klass_gap(int), but we agreed elsewhere (#5585) that we don't want to access partly initialized oops as such. We should use the HeapWord* initialization variants in Zero, too.
> 
> Note: we could take that even further and replace the initialization in Zero with ObjAllocator::initialize() call, but that would also have to remove the storestore fence, and possibly adopt ObjAllocator to avoid clearing in already-zeroed TLABs, all of which would have wider consequences and would be a matter for separate PR.
> 
> Testing:
>  - [x] Build (for klass_gap methods removal)
>  - [ ] GHA for Zero stuff

This pull request has now been integrated.

Changeset: afd2805e
Author:    Roman Kennke <rkennke at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/afd2805ef2fe72aee04b84956dba5bb5c012ff3c
Stats:     18 lines in 3 files changed: 3 ins; 13 del; 2 mod

8279534: Consolidate and remove oopDesc::klass_gap methods

Reviewed-by: shade, dholmes

-------------

PR: https://git.openjdk.java.net/jdk/pull/7008


More information about the hotspot-dev mailing list