RFR: 8280867: Cpuid1Ecx feature parsing is incorrect for AMD CPUs
Dean Long
dlong at openjdk.java.net
Mon Jan 31 23:15:09 UTC 2022
On Mon, 31 Jan 2022 11:26:29 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> See discussion in the bug. AFAICS, the fix is to "just" shift the flags by one to match both Intel and AMD specs. I believe this is not a serious bug, because adjacent bits in AMD case are set on modern chips, and Intel detection code only uses `lzcnt` and `prefetchw` out of these flags, both with Intel-specific hacks that are dropped now.
>
> Additional testing:
> - [x] Linux x86_64 fastdebug on TR 3970X (Zen 2)
> - [x] Linux x86_64 fastdebug on i5-11500 (Rocket Lake)
> - [x] Eyeballing `-Xlog:os+cpu` on TR 3970X (Zen 2) -- no change in detected flags
> - [x] Eyeballing `-Xlog:os+cpu` on i5-11500 (Rocket Lake) -- no change in detected flags
Marked as reviewed by dlong (Reviewer).
-------------
PR: https://git.openjdk.java.net/jdk/pull/7287
More information about the hotspot-dev
mailing list