RFR: JDK-8289633: Forbid raw C-heap allocation functions in hotspot and fix findings [v2]
Thomas Stuefe
stuefe at openjdk.org
Mon Jul 4 07:29:42 UTC 2022
On Sun, 3 Jul 2022 13:13:51 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> A few small nits, but generally good.
>
> One stylistic question is the naming of functions in ALLOW_xxx macro uses. Sometimes they are explicitly in the global namespace (`::foo`), sometimes not, and sometimes the macro's name argument and the use(s) in the permissive code are different. At least the latter probably should be made consistent. Regularizing others might be worthwhile, in which case I suggest explicit global namespace qualification. Not sure how strongly I feel about that.
Thank you @kimbarrett for the review. I fixed those places you found. Seems I rushed the patch a bit. I unified the names in the ALLOW_ macros to all use global namespace scope.
Cheers, Thomas
-------------
PR: https://git.openjdk.org/jdk/pull/9356
More information about the hotspot-dev
mailing list