[jdk19] RFR: 8288759: GCC 12 fails to compile signature.cpp due to -Wstringop-overread [v2]

[Aleksey Shipilev]

On Sat, 25 Jun 2022 08:37:03 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Better fix the actual warning
>>  - Merge branch 'master' into JDK-8288759-gcc12-string-overread
>>  - Fix
>
> Changes requested by kbarrett (Reviewer).

@kimbarrett, @coleenp -- I redid the fix to fix the actual warning instead. I opted to return `limit` on the failure path + assert it does not actually happen in practice. It looks that returning `limit` is acceptable, as it rolls over to the "end of signature" on error. We can make that `fatal()` instead, but I don't like to penalize `release` builds unnecessarily.

-------------

PR: https://git.openjdk.org/jdk19/pull/49