RFR: JDK-8289633: Forbid raw C-heap allocation functions in hotspot and fix findings [v2]
Thomas Stuefe
stuefe at openjdk.org
Mon Jul 4 13:31:46 UTC 2022
On Mon, 4 Jul 2022 10:41:32 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Forgot one..
>> - Review feedback Kim
>
> src/hotspot/os/linux/os_perf_linux.cpp line 788:
>
>> 786: jio_snprintf(buffer, PATH_MAX, "/proc/%s/exe", _entry->d_name);
>> 787: buffer[PATH_MAX - 1] = '\0';
>> 788: ALLOW_C_FUNCTION(::realpath, return realpath(buffer, _exePath);)
>
> Shouldn't this be using `os::Posix::realpath`?
Yes, I agree. Fixed.
-------------
PR: https://git.openjdk.org/jdk/pull/9356
More information about the hotspot-dev
mailing list