RFR: 8288971: AArch64: Clean up stack and register handling in interpreter [v4]

Andrew Haley aph at openjdk.org
Mon Jul 4 15:47:41 UTC 2022


On Thu, 30 Jun 2022 15:14:29 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> There are several places in the interpreter that could be improved.
>> 
>> 1. We use r13 to pass the caller's SP to a callee through adapters. r13 is not a callee-saved register in the native ABI, so this causes some complications. Use a callee-saved register.
>> 2. We frequently recalculate the location where the native SP needs to go. We have a spare slot in the interpreter frame, so we should calculate it once, when the frame is created, and use it.
>> 3. Related to 1, we should clearly label all the places where the caller's SP is passed to a callee.
>
> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update templateInterpreterGenerator_aarch64.cpp

On 7/4/22 16:15, Alan Bateman wrote:
> tier1 or run hotspot/jtreg:jdk_loom. I think most of the jdk/jdk_loom tests will fail too, but for other reasons.

https://github.com/openjdk/jdk/pull/9367

Tests are running now.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

-------------

PR: https://git.openjdk.org/jdk/pull/9239


More information about the hotspot-dev mailing list