RFR: JDK-8289633: Forbid raw C-heap allocation functions in hotspot and fix findings [v3]
    Thomas Stuefe 
    stuefe at openjdk.org
       
    Tue Jul  5 03:46:41 UTC 2022
    
    
  
On Mon, 4 Jul 2022 23:49:20 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use our realpath() wrapper in os_perf_linux.cpp
>
> src/hotspot/share/compiler/compilerEvent.cpp line 105:
> 
>> 103: 
>> 104:     index = phase_names->length();
>> 105:     phase_names->append(use_strdup ? os::strdup(phase_name) : phase_name);
> 
> Where is the `os::free()` to pair with this allocation?
AFAICS this is a static global table of phase names that only ever grows and is never deleted.
-------------
PR: https://git.openjdk.org/jdk/pull/9356
    
    
More information about the hotspot-dev
mailing list