RFR: 8289710: Move Suspend/Resume classes out of os.hpp [v2]

Ioi Lam iklam at openjdk.org
Tue Jul 5 16:51:25 UTC 2022


On Tue, 5 Jul 2022 12:57:52 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   moved SuspendResume class to os/posix directory
>
> src/hotspot/share/runtime/suspend.cpp line 34:
> 
>> 32: }
>> 33: 
>> 34: #ifndef _WINDOWS
> 
> I'm curious why this isn't needed on windows? With this ifndef this is really posix-only code and so should be in os/posix/suspend_posix.cpp, or at least os_posix.cpp.

The `SuspendResume` class is used only inside signals_posix.cpp (which requires the field `SuspendResume OsThread::sr` to be declared in osThread_{aix, bsd, linux}.hpp). I moved this class into the os/posix directory. I also renamed suspend.hpp to suspendedThreadTask.hpp.

-------------

PR: https://git.openjdk.org/jdk/pull/9371


More information about the hotspot-dev mailing list