RFR: 8289778: ZGC: incorrect use of os::free() for mountpoint string handling after JDK-8289633
Thomas Stuefe
stuefe at openjdk.org
Thu Jul 7 12:45:40 UTC 2022
On Thu, 7 Jul 2022 01:11:50 GMT, Jie Fu <jiefu at openjdk.org> wrote:
>>> I'm curious, which tests did show the bug? Because I ran GHAs and a selection of our nightlies.
>>
>> This bug can be exposed by `java -XX:+UseZGC` on some of our cloud machines with os/tlinux, not all the platforms would crash (e.g., I didn't reproduce it on Ubuntu20.04).
>
>> Hi @DamonFool ,
>>
>> thanks for the quick fix. Embarrassing, I should have catched this.
>>
>> Can you please add `#include "utilities/globalDefinitions.hpp"` for the ALLOW_... macros?
>>
>> Otherwise, apart from the comment changes below, fine.
>>
>> Cheers, Thomas
>
> Thanks @tstuefe for your review.
>
> All the comments have been addressed.
> Thanks.
Hi @DamonFool, can you pls integrate this fix?
-------------
PR: https://git.openjdk.org/jdk/pull/9387
More information about the hotspot-dev
mailing list