RFR: 8289778: ZGC: incorrect use of os::free() for mountpoint string handling after JDK-8289633 [v3]

[Martin Doerr]

On Thu, 7 Jul 2022 12:55:02 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> src/hotspot/os/linux/gc/z/zMountPoint_linux.cpp line 31:
>> 
>>> 29: #include "runtime/globals.hpp"
>>> 30: #include "runtime/os.hpp"
>>> 31: #include "utilities/globalDefinitions.hpp"
>> 
>> Did you add this by intention or was it added by your IDE?
>
>> Did you add this by intention or was it added by your IDE?
> 
> It was added by intention.
> Any question?
> Thanks.

No, that's fine. My VS code often adds it, but it's not strictly required.

>> src/hotspot/os/linux/gc/z/zMountPoint_linux.cpp line 93:
>> 
>>> 91:   }
>>> 92: 
>>> 93:   // readline will return malloced memory. Need raw ::free, not os::free.
>> 
>> You mean `getline`?
>
>> You mean `getline`?
> 
> Yes.
> Sorry, it's too late.
> 
> Shall we open another issue to fix it?

Not so important. Thanks for fixing the crashes!

-------------

PR: https://git.openjdk.org/jdk/pull/9387